diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2016-07-06 12:19:09 +0000 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2016-07-12 10:14:41 +0530 |
| commit | 6a2cf55db33d13474b7c339d3e4cef8993508a40 (patch) | |
| tree | 2f833a2c15602fd237e646741f0a79548c10f047 /drivers/dma/qcom/hidma_mgmt.c | |
| parent | d3183447ef561efe7e734cb4bc331519c276a786 (diff) | |
| download | linux-6a2cf55db33d13474b7c339d3e4cef8993508a40.tar.gz linux-6a2cf55db33d13474b7c339d3e4cef8993508a40.tar.bz2 linux-6a2cf55db33d13474b7c339d3e4cef8993508a40.zip | |
dmaengine: qcom_hidma: fix return value check in hidma_mgmt_of_populate_channels()
In case of error, the function platform_device_register_full()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma/qcom/hidma_mgmt.c')
| -rw-r--r-- | drivers/dma/qcom/hidma_mgmt.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c index c0e365321310..6416dededd67 100644 --- a/drivers/dma/qcom/hidma_mgmt.c +++ b/drivers/dma/qcom/hidma_mgmt.c @@ -371,8 +371,8 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) pdevinfo.size_data = 0; pdevinfo.dma_mask = DMA_BIT_MASK(64); new_pdev = platform_device_register_full(&pdevinfo); - if (!new_pdev) { - ret = -ENODEV; + if (IS_ERR(new_pdev)) { + ret = PTR_ERR(new_pdev); goto out; } of_dma_configure(&new_pdev->dev, child); |