diff options
| author | Anton Vasilyev <vasilyev@ispras.ru> | 2017-08-10 18:54:25 +0300 |
|---|---|---|
| committer | Vinod Koul <vinod.koul@intel.com> | 2017-08-21 21:51:00 +0530 |
| commit | a63efead7f8eeefcf08e4e7d0b033ac552f7da23 (patch) | |
| tree | ffa74d8046933d51f107d2d51854549721d5313c /drivers/dma | |
| parent | 8e7341750b95b3732ba19e65745edbcb46ee6241 (diff) | |
| download | linux-a63efead7f8eeefcf08e4e7d0b033ac552f7da23.tar.gz linux-a63efead7f8eeefcf08e4e7d0b033ac552f7da23.tar.bz2 linux-a63efead7f8eeefcf08e4e7d0b033ac552f7da23.zip | |
dmaengine: qcom_hidma: avoid freeing an uninitialized pointer
If device_node np doesn't contain child or first child doesn't have
property "reg" then hidma_mgmt_of_populate_channels() perfoms
deallocation on uninitialized local variable res.
The patch adds res initialization by NULL.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Reviewed-by: Sinan Kaya <okaya@codeaurora.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/qcom/hidma_mgmt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c index c45e244b2d99..7335e2eb9b72 100644 --- a/drivers/dma/qcom/hidma_mgmt.c +++ b/drivers/dma/qcom/hidma_mgmt.c @@ -358,7 +358,7 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np) struct platform_device_info pdevinfo; struct of_phandle_args out_irq; struct device_node *child; - struct resource *res; + struct resource *res = NULL; const __be32 *cell; int ret = 0, size, i, num; u64 addr, addr_size; |