summaryrefslogtreecommitdiffstats
path: root/drivers/edac/thunderx_edac.c
diff options
context:
space:
mode:
authorYeqi Fu <asuk4.q@gmail.com>2023-05-18 01:31:11 +0800
committerBorislav Petkov (AMD) <bp@alien8.de>2023-06-06 23:04:56 +0200
commitbf5c04ddd378dbd62d41d9c5bd18cca03bee2946 (patch)
tree0bfd61c5997293b32dacb2fb3fd1d4970ca2affd /drivers/edac/thunderx_edac.c
parentac9a78681b921877518763ba0e89202254349d1b (diff)
downloadlinux-bf5c04ddd378dbd62d41d9c5bd18cca03bee2946.tar.gz
linux-bf5c04ddd378dbd62d41d9c5bd18cca03bee2946.tar.bz2
linux-bf5c04ddd378dbd62d41d9c5bd18cca03bee2946.zip
EDAC/thunderx: Check debugfs file creation retval properly
edac_debugfs_create_file() returns ERR_PTR by way of the respective debugfs function it calls, if an error occurs. The appropriate way to verify for errors is to use IS_ERR(). Do so. [ bp: Rewrite all text. ] Signed-off-by: Yeqi Fu <asuk4.q@gmail.com> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/20230517173111.365787-1-asuk4.q@gmail.com
Diffstat (limited to 'drivers/edac/thunderx_edac.c')
-rw-r--r--drivers/edac/thunderx_edac.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index 0bcd9f02c84a..b9c5772da959 100644
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -481,7 +481,7 @@ static int thunderx_create_debugfs_nodes(struct dentry *parent,
ent = edac_debugfs_create_file(attrs[i]->name, attrs[i]->mode,
parent, data, &attrs[i]->fops);
- if (!ent)
+ if (IS_ERR(ent))
break;
}