diff options
| author | Jeff Garzik <jeff@garzik.org> | 2006-10-10 02:58:14 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-10 16:29:37 -0700 |
| commit | 0968cf51b6f2ca8a951de4b976370189cf43bbdd (patch) | |
| tree | fd29fb864a516b4c52e26700f0b1d782857c9797 /drivers/firmware | |
| parent | 15e541feb340bc2a4caaf707ee5ad71a47fdd068 (diff) | |
| download | linux-0968cf51b6f2ca8a951de4b976370189cf43bbdd.tar.gz linux-0968cf51b6f2ca8a951de4b976370189cf43bbdd.tar.bz2 linux-0968cf51b6f2ca8a951de4b976370189cf43bbdd.zip | |
[PATCH] firmware/dcdbas: fix bug in error cleanup
The error path path mistakenly called sysfs_create_group() rather than
sysfs_remove_group(). They take the same arguments, so it's easy to
cut-n-paste such a bug.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/dcdbas.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c index 339f405ff708..8bcb58cd4ac0 100644 --- a/drivers/firmware/dcdbas.c +++ b/drivers/firmware/dcdbas.c @@ -559,7 +559,7 @@ static int __devinit dcdbas_probe(struct platform_device *dev) while (--i >= 0) sysfs_remove_bin_file(&dev->dev.kobj, dcdbas_bin_attrs[i]); - sysfs_create_group(&dev->dev.kobj, &dcdbas_attr_group); + sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group); return error; } } |