summaryrefslogtreecommitdiffstats
path: root/drivers/firmware
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@gmail.com>2010-07-05 09:35:47 +0800
committerGreg Kroah-Hartman <gregkh@suse.de>2010-08-05 13:53:34 -0700
commite3ed249af8cb2f73fc6ef5494d2ddef43fb0ff19 (patch)
tree929b78904d87e976beaad97fe11d85934b8322a7 /drivers/firmware
parent5b232f753a842fa66eab86e51dc76e3929d853af (diff)
downloadlinux-e3ed249af8cb2f73fc6ef5494d2ddef43fb0ff19.tar.gz
linux-e3ed249af8cb2f73fc6ef5494d2ddef43fb0ff19.tar.bz2
linux-e3ed249af8cb2f73fc6ef5494d2ddef43fb0ff19.zip
dcdbas: remove a redundant smi_data_buf_free in dcdbas_exit
smi_data_buf_free is called twice in current implementation. The second call simply return because smi_data_buf is set to NULL in first call. This patch removes the second smi_data_buf_free call. Signed-off-by: Axel Lin <axel.lin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/dcdbas.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
index aa9bc9e980e1..69ad529d92fb 100644
--- a/drivers/firmware/dcdbas.c
+++ b/drivers/firmware/dcdbas.c
@@ -634,9 +634,6 @@ static void __exit dcdbas_exit(void)
* before platform_device_unregister
*/
unregister_reboot_notifier(&dcdbas_reboot_nb);
- smi_data_buf_free();
- platform_device_unregister(dcdbas_pdev);
- platform_driver_unregister(&dcdbas_driver);
/*
* We have to free the buffer here instead of dcdbas_remove
@@ -645,6 +642,8 @@ static void __exit dcdbas_exit(void)
* released.
*/
smi_data_buf_free();
+ platform_device_unregister(dcdbas_pdev);
+ platform_driver_unregister(&dcdbas_driver);
}
module_init(dcdbas_init);