diff options
| author | Eddie James <eajames@linux.ibm.com> | 2021-02-09 11:12:33 -0600 |
|---|---|---|
| committer | Joel Stanley <joel@jms.id.au> | 2021-06-04 14:29:57 +0930 |
| commit | 614f0a50c9df6e56e555b66f2bdd0495d4c4aef1 (patch) | |
| tree | dff47ba1c8ca9f508bb77bd798cbc841ae143915 /drivers/fsi | |
| parent | 8a4659be08576141f47d47d94130eb148cb5f0df (diff) | |
| download | linux-614f0a50c9df6e56e555b66f2bdd0495d4c4aef1.tar.gz linux-614f0a50c9df6e56e555b66f2bdd0495d4c4aef1.tar.bz2 linux-614f0a50c9df6e56e555b66f2bdd0495d4c4aef1.zip | |
fsi: occ: Log error for checksum failure
Log an error if the response checksum doesn't match the
calculated checksum.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Link: https://lore.kernel.org/r/20210209171235.20624-3-eajames@linux.ibm.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
Diffstat (limited to 'drivers/fsi')
| -rw-r--r-- | drivers/fsi/fsi-occ.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c index dc74bffedd72..b223f0ef337b 100644 --- a/drivers/fsi/fsi-occ.c +++ b/drivers/fsi/fsi-occ.c @@ -223,7 +223,8 @@ static const struct file_operations occ_fops = { .release = occ_release, }; -static int occ_verify_checksum(struct occ_response *resp, u16 data_length) +static int occ_verify_checksum(struct occ *occ, struct occ_response *resp, + u16 data_length) { /* Fetch the two bytes after the data for the checksum. */ u16 checksum_resp = get_unaligned_be16(&resp->data[data_length]); @@ -238,8 +239,11 @@ static int occ_verify_checksum(struct occ_response *resp, u16 data_length) for (i = 0; i < data_length; ++i) checksum += resp->data[i]; - if (checksum != checksum_resp) + if (checksum != checksum_resp) { + dev_err(occ->dev, "Bad checksum: %04x!=%04x\n", checksum, + checksum_resp); return -EBADMSG; + } return 0; } @@ -533,7 +537,7 @@ int fsi_occ_submit(struct device *dev, const void *request, size_t req_len, } *resp_len = resp_data_length + 7; - rc = occ_verify_checksum(resp, resp_data_length); + rc = occ_verify_checksum(occ, resp, resp_data_length); done: mutex_unlock(&occ->occ_lock); |