diff options
author | Sebastian Siewior <bigeasy@linutronix.de> | 2015-11-26 21:23:48 +0100 |
---|---|---|
committer | Richard Weinberger <richard@nod.at> | 2015-12-16 22:52:46 +0100 |
commit | 1a31b20cd81d5cbc7ec6e24cb08066009a1ca32d (patch) | |
tree | cc247bb7803e3576995306bf143c76a95b34c040 /drivers/gpio/gpio-lynxpoint.c | |
parent | 2e69d4912f2fc9d4cd952311d58ceae1cd83057b (diff) | |
download | linux-1a31b20cd81d5cbc7ec6e24cb08066009a1ca32d.tar.gz linux-1a31b20cd81d5cbc7ec6e24cb08066009a1ca32d.tar.bz2 linux-1a31b20cd81d5cbc7ec6e24cb08066009a1ca32d.zip |
mtd: ubi: fixup error correction in do_sync_erase()
Since fastmap we gained do_sync_erase(). This function can return an error
and its error handling isn't obvious. First the memory allocation for
struct ubi_work can fail and as such struct ubi_wl_entry is leaked.
However if the memory allocation succeeds then the tail function takes
care of the struct ubi_wl_entry. A free here could result in a double
free.
To make the error handling simpler, I split the tail function into one
piece which does the work and another which frees the struct ubi_work
which is passed as argument. As result do_sync_erase() can keep the
struct on stack and we get rid of one error source.
Cc: <stable@vger.kernel.org>
Fixes: 8199b901a ("UBI: Add fastmap support to the WL sub-system")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'drivers/gpio/gpio-lynxpoint.c')
0 files changed, 0 insertions, 0 deletions