diff options
| author | Neil Armstrong <narmstrong@baylibre.com> | 2018-02-15 11:19:36 +0100 |
|---|---|---|
| committer | Neil Armstrong <narmstrong@baylibre.com> | 2018-02-20 10:03:52 +0100 |
| commit | e88230a3744a71a0b5ecfb45e08ddfe1c884e50d (patch) | |
| tree | fb1b5907fe2c0d8b50dc91d0ca9c49b6707be96e /drivers/gpu/drm/meson/meson_drv.h | |
| parent | b8ff1802815913aad52695898cccbc9f77b7e726 (diff) | |
| download | linux-e88230a3744a71a0b5ecfb45e08ddfe1c884e50d.tar.gz linux-e88230a3744a71a0b5ecfb45e08ddfe1c884e50d.tar.bz2 linux-e88230a3744a71a0b5ecfb45e08ddfe1c884e50d.zip | |
drm/meson: fix vsync buffer update
The plane buffer address/stride/height was incorrectly updated in the
plane_atomic_update operation instead of the vsync irq.
This patch delays this operation in the vsync irq along with the
other plane delayed setup.
This issue was masked using legacy framebuffer and X11 modesetting, but
is clearly visible using gbm rendering when buffer is submitted late after
vblank, like using software decoding and OpenGL rendering in Kodi.
With this patch, tearing and other artifacts disappears completely.
Cc: Michal Lazo <michal.lazo@gmail.com>
Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1518689976-23292-1-git-send-email-narmstrong@baylibre.com
Diffstat (limited to 'drivers/gpu/drm/meson/meson_drv.h')
| -rw-r--r-- | drivers/gpu/drm/meson/meson_drv.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/meson/meson_drv.h b/drivers/gpu/drm/meson/meson_drv.h index 5e8b392b9d1f..8450d6ac8c9b 100644 --- a/drivers/gpu/drm/meson/meson_drv.h +++ b/drivers/gpu/drm/meson/meson_drv.h @@ -43,6 +43,9 @@ struct meson_drm { bool osd1_commit; uint32_t osd1_ctrl_stat; uint32_t osd1_blk0_cfg[5]; + uint32_t osd1_addr; + uint32_t osd1_stride; + uint32_t osd1_height; } viu; struct { |