summaryrefslogtreecommitdiffstats
path: root/drivers/gpu
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-01-13 10:49:00 +0300
committerEric Anholt <eric@anholt.net>2017-01-17 21:12:59 +1100
commit21ccc32496b2f63228f5232b3ac0e426e8fb3c31 (patch)
tree5e9c02865757f9bb0db41f501116aba734d564e7 /drivers/gpu
parent7622b25543665567d8830a63210385b7d705924b (diff)
downloadlinux-21ccc32496b2f63228f5232b3ac0e426e8fb3c31.tar.gz
linux-21ccc32496b2f63228f5232b3ac0e426e8fb3c31.tar.bz2
linux-21ccc32496b2f63228f5232b3ac0e426e8fb3c31.zip
drm/vc4: fix a bounds check
We accidentally return success even if vc4_full_res_bounds_check() fails. Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Eric Engestrom <eric@engestrom.ch> Reviewed-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'drivers/gpu')
-rw-r--r--drivers/gpu/drm/vc4/vc4_render_cl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_render_cl.c b/drivers/gpu/drm/vc4/vc4_render_cl.c
index 08886a309757..5cdd003605f5 100644
--- a/drivers/gpu/drm/vc4/vc4_render_cl.c
+++ b/drivers/gpu/drm/vc4/vc4_render_cl.c
@@ -461,7 +461,7 @@ static int vc4_rcl_surface_setup(struct vc4_exec_info *exec,
}
ret = vc4_full_res_bounds_check(exec, *obj, surf);
- if (!ret)
+ if (ret)
return ret;
return 0;