diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-25 15:55:33 -0600 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2019-01-29 10:57:02 -0500 |
| commit | 2f10d823739680d2477ce34437e8a08a53117f40 (patch) | |
| tree | a2dcb68b8de67c1216f6c0f6848bcd28a596fc85 /drivers/gpu | |
| parent | afeff4c16edaa6275b903f82b0561406259aa3a3 (diff) | |
| download | linux-2f10d823739680d2477ce34437e8a08a53117f40.tar.gz linux-2f10d823739680d2477ce34437e8a08a53117f40.tar.bz2 linux-2f10d823739680d2477ce34437e8a08a53117f40.zip | |
drm/amd/powerplay: Fix missing break in switch
Add missing break statement in order to prevent the code from falling
through to the default case.
The resoning for this is that pclk_vol_table is an automatic variable.
So, it makes no sense to update it just before falling through to the
default case and return -EINVAL.
This bug was found thanks to the ongoing efforts to enabling
-Wimplicit-fallthrough.
Fixes: cd70f3d6e3fa ("drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c index f95c5f50eb0f..5273de3c5b98 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c @@ -1033,6 +1033,7 @@ static int smu10_get_clock_by_type_with_latency(struct pp_hwmgr *hwmgr, break; case amd_pp_dpp_clock: pclk_vol_table = pinfo->vdd_dep_on_dppclk; + break; default: return -EINVAL; } |