summaryrefslogtreecommitdiffstats
path: root/drivers/hid/hid-lenovo.c
diff options
context:
space:
mode:
authorJamie Lentin <jm@lentin.co.uk>2014-07-26 15:42:27 +0100
committerJiri Kosina <jkosina@suse.cz>2014-07-29 11:24:47 +0200
commite0a6aad6014be2d4fbb24dfb8e046308da1df8c8 (patch)
treedd1ffc4bda887fcc4c301857c45c64592eae4e9b /drivers/hid/hid-lenovo.c
parent6a5b414b4216be0fb7d26aadcf35de0fa24a03e3 (diff)
downloadlinux-e0a6aad6014be2d4fbb24dfb8e046308da1df8c8.tar.gz
linux-e0a6aad6014be2d4fbb24dfb8e046308da1df8c8.tar.bz2
linux-e0a6aad6014be2d4fbb24dfb8e046308da1df8c8.zip
HID: lenovo: Don't call function in condition, show error codes
Signed-off-by: Jamie Lentin <jm@lentin.co.uk> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-lenovo.c')
-rw-r--r--drivers/hid/hid-lenovo.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index a56b9e7413ce..f96bf095670a 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -350,6 +350,7 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev)
size_t name_sz = strlen(dev_name(dev)) + 16;
char *name_mute, *name_micmute;
int i;
+ int ret;
/*
* Only register extra settings against subdevice where input_mapping
@@ -368,10 +369,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev)
if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 3, 0, 2))
return -ENODEV;
- if (sysfs_create_group(&hdev->dev.kobj,
- &lenovo_attr_group_tpkbd)) {
- hid_warn(hdev, "Could not create sysfs group\n");
- }
+ ret = sysfs_create_group(&hdev->dev.kobj, &lenovo_attr_group_tpkbd);
+ if (ret)
+ hid_warn(hdev, "Could not create sysfs group: %d\n", ret);
data_pointer = devm_kzalloc(&hdev->dev,
sizeof(struct lenovo_drvdata_tpkbd),