summaryrefslogtreecommitdiffstats
path: root/drivers/hv/channel.c
diff options
context:
space:
mode:
authorDexuan Cui <decui@microsoft.com>2015-12-14 16:01:48 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-12-14 19:15:05 -0800
commit64b7faf903dae2df94d89edf2c688b16751800e4 (patch)
treefced91ec8e59aaea3457680c2433cbb13e484ea8 /drivers/hv/channel.c
parent63d55b2aeb5e4faa170316fee73c3c47ea9268c7 (diff)
downloadlinux-64b7faf903dae2df94d89edf2c688b16751800e4.tar.gz
linux-64b7faf903dae2df94d89edf2c688b16751800e4.tar.bz2
linux-64b7faf903dae2df94d89edf2c688b16751800e4.zip
Drivers: hv: vmbus: do sanity check of channel state in vmbus_close_internal()
This fixes an incorrect assumption of channel state in the function. Signed-off-by: Dexuan Cui <decui@microsoft.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hv/channel.c')
-rw-r--r--drivers/hv/channel.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index f7f3d5ccd6bd..00e1be775908 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -512,6 +512,18 @@ static int vmbus_close_internal(struct vmbus_channel *channel)
tasklet = hv_context.event_dpc[channel->target_cpu];
tasklet_disable(tasklet);
+ /*
+ * In case a device driver's probe() fails (e.g.,
+ * util_probe() -> vmbus_open() returns -ENOMEM) and the device is
+ * rescinded later (e.g., we dynamically disble an Integrated Service
+ * in Hyper-V Manager), the driver's remove() invokes vmbus_close():
+ * here we should skip most of the below cleanup work.
+ */
+ if (channel->state != CHANNEL_OPENED_STATE) {
+ ret = -EINVAL;
+ goto out;
+ }
+
channel->state = CHANNEL_OPEN_STATE;
channel->sc_creation_callback = NULL;
/* Stop callback and cancel the timer asap */