diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2023-01-07 13:18:13 -0800 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2023-03-16 20:29:02 +0100 |
| commit | e9d373c3feffc7fb36927837254c25081b3da4a9 (patch) | |
| tree | 21d588390c15042741c131cd1f3c9fef7038040b /drivers/i2c/busses | |
| parent | 89151f6b007915fca95c5225cd1c37a419ba8cb9 (diff) | |
| download | linux-e9d373c3feffc7fb36927837254c25081b3da4a9.tar.gz linux-e9d373c3feffc7fb36927837254c25081b3da4a9.tar.bz2 linux-e9d373c3feffc7fb36927837254c25081b3da4a9.zip | |
i2c: cadence: Remove always false ternary operator
When selecting the clock dividers the Cadence I2C driver skips settings
where the resulting I2C bus frequency is larger than the requested
frequency.
If the resulting frequency is lower it will compute the error to actual
frequency. When calculating the difference it also handles the case where
the resulting frequency is larger.
Since the resulting frequency is always smaller or equal the computation of
the error can be simplified by only considering this case.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c/busses')
| -rw-r--r-- | drivers/i2c/busses/i2c-cadence.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index b5d22e7282c2..bec50bfe7aad 100644 --- a/drivers/i2c/busses/i2c-cadence.c +++ b/drivers/i2c/busses/i2c-cadence.c @@ -1030,8 +1030,7 @@ static int cdns_i2c_calc_divs(unsigned long *f, unsigned long input_clk, if (actual_fscl > fscl) continue; - current_error = ((actual_fscl > fscl) ? (actual_fscl - fscl) : - (fscl - actual_fscl)); + current_error = fscl - actual_fscl; if (last_error > current_error) { calc_div_a = div_a; |