diff options
| author | Sergey Shtylyov <s.shtylyov@omp.ru> | 2021-07-04 17:45:25 +0300 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-08-19 19:18:24 +0200 |
| commit | d6840a5e370b7ea4fde16ce2caf431bcc87f9a75 (patch) | |
| tree | d0700aa780d930bf0654ea16ae8228ff65ec772c /drivers/i2c | |
| parent | a1299505162ad00def3573260c2c68b9c8e8d697 (diff) | |
| download | linux-d6840a5e370b7ea4fde16ce2caf431bcc87f9a75.tar.gz linux-d6840a5e370b7ea4fde16ce2caf431bcc87f9a75.tar.bz2 linux-d6840a5e370b7ea4fde16ce2caf431bcc87f9a75.zip | |
i2c: s3c2410: fix IRQ check
Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful). Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...
Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-s3c2410.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 4d82761e1585..b49a1b170bb2 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -1137,7 +1137,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) */ if (!(i2c->quirks & QUIRK_POLL)) { i2c->irq = ret = platform_get_irq(pdev, 0); - if (ret <= 0) { + if (ret < 0) { dev_err(&pdev->dev, "cannot find IRQ\n"); clk_unprepare(i2c->clk); return ret; |