diff options
| author | Håkon Bugge <haakon.bugge@oracle.com> | 2017-04-28 13:06:54 +0200 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2017-05-01 15:04:23 -0400 |
| commit | b03ee4ca0cec348c84dccf08aaec2454c4d236c2 (patch) | |
| tree | 0eb69d8a7690160a0984f17354cdc4965ec28c45 /drivers/infiniband | |
| parent | 898782883501798284a10d1467b11dd2a48270cf (diff) | |
| download | linux-b03ee4ca0cec348c84dccf08aaec2454c4d236c2.tar.gz linux-b03ee4ca0cec348c84dccf08aaec2454c4d236c2.tar.bz2 linux-b03ee4ca0cec348c84dccf08aaec2454c4d236c2.zip | |
IB/mlx4: Fix incorrect order of formal and actual parameters
The last two actual parameters when calling id_map_find_by_sl_id()
from id_map_get() are swapped. However, the same formal parameters to
id_map_get() have them swapped as well, inverting the effect of the
first error.
This commit improves readability, but makes no functional change to
the code.
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: Wengang Wang <wen.gang.wang@oracle.com>
Reviewed-by: Knut Omang <knut.omang@oracle.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/hw/mlx4/cm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/hw/mlx4/cm.c b/drivers/infiniband/hw/mlx4/cm.c index 61f63fe63c3c..1e6c526450d9 100644 --- a/drivers/infiniband/hw/mlx4/cm.c +++ b/drivers/infiniband/hw/mlx4/cm.c @@ -279,14 +279,14 @@ id_map_alloc(struct ib_device *ibdev, int slave_id, u32 sl_cm_id) } static struct id_map_entry * -id_map_get(struct ib_device *ibdev, int *pv_cm_id, int sl_cm_id, int slave_id) +id_map_get(struct ib_device *ibdev, int *pv_cm_id, int slave_id, int sl_cm_id) { struct id_map_entry *ent; struct mlx4_ib_sriov *sriov = &to_mdev(ibdev)->sriov; spin_lock(&sriov->id_map_lock); if (*pv_cm_id == -1) { - ent = id_map_find_by_sl_id(ibdev, sl_cm_id, slave_id); + ent = id_map_find_by_sl_id(ibdev, slave_id, sl_cm_id); if (ent) *pv_cm_id = (int) ent->pv_cm_id; } else |