summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorIrina Tirdea <irina.tirdea@intel.com>2015-06-09 11:03:15 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2015-06-09 11:23:26 -0700
commit0e0432f04ee5d73b45faefc7bbb63b75fcaefa42 (patch)
treeaa69288f15d3fde705ed2810917d6026935d703e /drivers/input
parent0dfb35bd39d16ca2b69d5ddaa76a143c814eca45 (diff)
downloadlinux-0e0432f04ee5d73b45faefc7bbb63b75fcaefa42.tar.gz
linux-0e0432f04ee5d73b45faefc7bbb63b75fcaefa42.tar.bz2
linux-0e0432f04ee5d73b45faefc7bbb63b75fcaefa42.zip
Input: goodix - fix variable length array warning
Fix sparse warning: drivers/input/touchscreen/goodix.c:182:26: warning: Variable length array is used. Replace the variable length array with fixed length. Some Goodix devices have maximum 5 touch points, while others have 10 touch points. Using the maximum length (80 bytes) for all devices will lead to wasting 40 bytes on stack when using devices with maximum 5 touch points. However, that is preferable to using kmalloc which will use even more resources. Signed-off-by: Irina Tirdea <irina.tirdea@intel.com> Acked-by: Bastien Nocera <hadess@hadess.net> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/touchscreen/goodix.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 099fc466bd16..6457033439d5 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -147,7 +147,7 @@ static void goodix_ts_report_touch(struct goodix_ts_data *ts, u8 *coor_data)
*/
static void goodix_process_events(struct goodix_ts_data *ts)
{
- u8 point_data[1 + GOODIX_CONTACT_SIZE * ts->max_touch_num];
+ u8 point_data[1 + GOODIX_CONTACT_SIZE * GOODIX_MAX_CONTACTS];
int touch_num;
int i;