summaryrefslogtreecommitdiffstats
path: root/drivers/input
diff options
context:
space:
mode:
authorFuqian Huang <huangfq.daxian@gmail.com>2019-07-13 01:05:19 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2019-07-13 01:43:12 -0700
commite2c063c8970044033dac9cedc686db27008e4bb1 (patch)
tree06133cde16d9725e53581065e75c3b0564c0932a /drivers/input
parent2a017fd82c5402b3c8df5e3d6e5165d9e6147dc1 (diff)
downloadlinux-e2c063c8970044033dac9cedc686db27008e4bb1.tar.gz
linux-e2c063c8970044033dac9cedc686db27008e4bb1.tar.bz2
linux-e2c063c8970044033dac9cedc686db27008e4bb1.zip
Input: auo-pixcir-ts - switch to using devm_add_action_or_reset()
devm_add_action_or_reset() is introduced as a helper function which internally calls devm_add_action(). If devm_add_action() fails then it will execute the action mentioned and return the error code. This reduce source code size (avoid writing the action twice) and reduce the likelyhood of bugs. Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/touchscreen/auo-pixcir-ts.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
index df8ca856393b..02507c0b6641 100644
--- a/drivers/input/touchscreen/auo-pixcir-ts.c
+++ b/drivers/input/touchscreen/auo-pixcir-ts.c
@@ -612,9 +612,8 @@ static int auo_pixcir_probe(struct i2c_client *client,
return error;
}
- error = devm_add_action(&client->dev, auo_pixcir_reset, ts);
+ error = devm_add_action_or_reset(&client->dev, auo_pixcir_reset, ts);
if (error) {
- auo_pixcir_reset(ts);
dev_err(&client->dev, "failed to register reset action, %d\n",
error);
return error;