diff options
| author | Lukasz Odzioba <lukasz.odzioba@intel.com> | 2019-05-20 15:41:28 +0200 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2019-05-27 16:14:49 +0200 |
| commit | f780a8dc196db1c41b5da21ecfa27e83ee5fb776 (patch) | |
| tree | 28ffc920a4d7d6ee7187e1d85a6f5ec356790091 /drivers/iommu | |
| parent | d7af4d987dfa31c5d715e940a447ea959f89e575 (diff) | |
| download | linux-f780a8dc196db1c41b5da21ecfa27e83ee5fb776.tar.gz linux-f780a8dc196db1c41b5da21ecfa27e83ee5fb776.tar.bz2 linux-f780a8dc196db1c41b5da21ecfa27e83ee5fb776.zip | |
iommu/vt-d: Remove unnecessary rcu_read_locks
We use RCU's for rarely updated lists like iommus, rmrr, atsr units.
I'm not sure why domain_remove_dev_info() in domain_exit() was surrounded
by rcu_read_lock. Lock was present before refactoring in d160aca527,
but it was related to rcu list, not domain_remove_dev_info function.
dmar_remove_one_dev_info() doesn't touch any of those lists, so it doesn't
require a lock. In fact it is called 6 times without it anyway.
Fixes: d160aca5276d ("iommu/vt-d: Unify domain->iommu attach/detachment")
Signed-off-by: Lukasz Odzioba <lukasz.odzioba@intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu')
| -rw-r--r-- | drivers/iommu/intel-iommu.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index a209199f3af6..1b7ad80c0537 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -1911,9 +1911,7 @@ static void domain_exit(struct dmar_domain *domain) struct page *freelist; /* Remove associated devices and clear attached or cached domains */ - rcu_read_lock(); domain_remove_dev_info(domain); - rcu_read_unlock(); /* destroy iovas */ put_iova_domain(&domain->iovad); @@ -5254,9 +5252,7 @@ static int intel_iommu_attach_device(struct iommu_domain *domain, old_domain = find_domain(dev); if (old_domain) { - rcu_read_lock(); dmar_remove_one_dev_info(dev); - rcu_read_unlock(); if (!domain_type_is_vm_or_si(old_domain) && list_empty(&old_domain->devices)) |