diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-01-21 03:02:48 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-01-21 15:44:58 -0500 |
commit | 56567c6f8751c633581ca7c8e1cf08eed503f5ea (patch) | |
tree | ed95b14cd626f67ebea161f7fd8b8a2692745915 /drivers/isdn/divert | |
parent | b820bb6b996966d93a5442b5fbf803ea58e7f487 (diff) | |
download | linux-56567c6f8751c633581ca7c8e1cf08eed503f5ea.tar.gz linux-56567c6f8751c633581ca7c8e1cf08eed503f5ea.tar.bz2 linux-56567c6f8751c633581ca7c8e1cf08eed503f5ea.zip |
drivers/net/ethernet/sfc/ptp.c: adjust duplicate test
Delete successive tests to the same location. rc was previously tested and
not subsequently updated. efx_phc_adjtime can return an error code, so the
call is updated so that is tested instead.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@s exists@
local idexpression y;
expression x,e;
@@
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn/divert')
0 files changed, 0 insertions, 0 deletions