diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2010-02-02 12:43:44 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-02-03 20:16:46 -0800 |
| commit | e23e11792a77c7d54f363841cd5e33074fb0c8c9 (patch) | |
| tree | 0d3cf838f24f20ac1e370f904af11b88c2e23a47 /drivers/isdn | |
| parent | 4bbd1a1903639f826215d76af74f4901efc34daa (diff) | |
| download | linux-e23e11792a77c7d54f363841cd5e33074fb0c8c9.tar.gz linux-e23e11792a77c7d54f363841cd5e33074fb0c8c9.tar.bz2 linux-e23e11792a77c7d54f363841cd5e33074fb0c8c9.zip | |
hisax: timeout off by one in waitrecmsg()
With `while (timeout++ < maxdelay)' timeout reaches maxdelay + 1 after the
loop This is probably unlikely a problem in practice.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/hisax/isar.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hisax/isar.c b/drivers/isdn/hisax/isar.c index bfeb9b6aa043..6bde16c00fb5 100644 --- a/drivers/isdn/hisax/isar.c +++ b/drivers/isdn/hisax/isar.c @@ -138,7 +138,7 @@ waitrecmsg(struct IsdnCardState *cs, u_char *len, while((!(cs->BC_Read_Reg(cs, 0, ISAR_IRQBIT) & ISAR_IRQSTA)) && (timeout++ < maxdelay)) udelay(1); - if (timeout >= maxdelay) { + if (timeout > maxdelay) { printk(KERN_WARNING"isar recmsg IRQSTA timeout\n"); return(0); } |