summaryrefslogtreecommitdiffstats
path: root/drivers/leds/leds-lp3944.c
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2012-11-20 01:59:02 -0800
committerBryan Wu <cooloney@gmail.com>2012-11-26 14:43:55 -0800
commit4401e48737c4068604144a5c0ba23a9c82ea3a37 (patch)
treec7fb3a343e7a0871afb99ac9d644ad99b0bd953f /drivers/leds/leds-lp3944.c
parent5ebab74a711388fc30e6d839eee79aa06d1ce0af (diff)
downloadlinux-4401e48737c4068604144a5c0ba23a9c82ea3a37.tar.gz
linux-4401e48737c4068604144a5c0ba23a9c82ea3a37.tar.bz2
linux-4401e48737c4068604144a5c0ba23a9c82ea3a37.zip
leds: lp3944: Fix return value
Return the value obtained from i2c_smbus_read_byte_data() instead of -EINVAL. Silences the following smatch warning: drivers/leds/leds-lp3944.c:89 lp3944_reg_read() info: why not propagate 'tmp' from i2c_smbus_read_byte_data() instead of -22? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'drivers/leds/leds-lp3944.c')
-rw-r--r--drivers/leds/leds-lp3944.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/leds/leds-lp3944.c b/drivers/leds/leds-lp3944.c
index c298f7d9f535..b2d82e2d2e9d 100644
--- a/drivers/leds/leds-lp3944.c
+++ b/drivers/leds/leds-lp3944.c
@@ -86,7 +86,7 @@ static int lp3944_reg_read(struct i2c_client *client, u8 reg, u8 *value)
tmp = i2c_smbus_read_byte_data(client, reg);
if (tmp < 0)
- return -EINVAL;
+ return tmp;
*value = tmp;