diff options
author | Elena Reshetova <elena.reshetova@intel.com> | 2017-10-20 10:37:37 +0300 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2017-10-24 15:09:51 -0400 |
commit | 6bdd079610d3a5de0f4eb78d8015bd530c291cd7 (patch) | |
tree | 82b65fc46466466ecaa8339e0d52126d8bcb4dab /drivers/md/dm-cache-target.c | |
parent | b0b4d7c6752a45c545bcdce647ccfa8fb27f0a06 (diff) | |
download | linux-6bdd079610d3a5de0f4eb78d8015bd530c291cd7.tar.gz linux-6bdd079610d3a5de0f4eb78d8015bd530c291cd7.tar.bz2 linux-6bdd079610d3a5de0f4eb78d8015bd530c291cd7.zip |
dm cache: convert dm_cache_metadata.ref_count from atomic_t to refcount_t
atomic_t variables are currently used to implement reference
counters with the following properties:
- counter is initialized to 1 using atomic_set()
- a resource is freed upon counter reaching zero
- once counter reaches zero, its further
increments aren't allowed
- counter schema uses basic atomic operations
(set, inc, inc_not_zero, dec_and_test, etc.)
Such atomic variables should be converted to a newly provided
refcount_t type and API that prevents accidental counter overflows
and underflows. This is important since overflows and underflows
can lead to use-after-free situation and be exploitable.
The variable dm_cache_metadata.ref_count is used as pure reference counter.
Convert it to refcount_t and fix up the operations.
Suggested-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Windsor <dwindsor@gmail.com>
Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com>
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-cache-target.c')
0 files changed, 0 insertions, 0 deletions