diff options
| author | Martin Wilck <mwilck@suse.com> | 2020-04-20 22:29:09 +0200 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2020-05-15 10:29:35 -0400 |
| commit | 2361ae595352dec015d14292f1b539242d8446d6 (patch) | |
| tree | 47bc57c7c09db1c151828c6ffe20689dfe46afc0 /drivers/md/dm-mpath.c | |
| parent | 27f5411a718c431c20007e3a2fbba6589942d04f (diff) | |
| download | linux-2361ae595352dec015d14292f1b539242d8446d6.tar.gz linux-2361ae595352dec015d14292f1b539242d8446d6.tar.bz2 linux-2361ae595352dec015d14292f1b539242d8446d6.zip | |
dm mpath: switch paths in dm_blk_ioctl() code path
SCSI LUN passthrough code such as qemu's "scsi-block" device model
pass every IO to the host via SG_IO ioctls. Currently, dm-multipath
calls choose_pgpath() only in the block IO code path, not in the ioctl
code path (unless current_pgpath is NULL). This has the effect that no
path switching and thus no load balancing is done for SCSI-passthrough
IO, unless the active path fails.
Fix this by using the same logic in multipath_prepare_ioctl() as in
multipath_clone_and_map().
Note: The allegedly best path selection algorithm, service-time,
still wouldn't work perfectly, because the io size of the current
request is always set to 0. Changing that for the IO passthrough
case would require the ioctl cmd and arg to be passed to dm's
prepare_ioctl() method.
Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-mpath.c')
| -rw-r--r-- | drivers/md/dm-mpath.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 3e500098132f..e0c800cf87a9 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -1918,7 +1918,7 @@ static int multipath_prepare_ioctl(struct dm_target *ti, int r; current_pgpath = READ_ONCE(m->current_pgpath); - if (!current_pgpath) + if (!current_pgpath || !test_bit(MPATHF_QUEUE_IO, &m->flags)) current_pgpath = choose_pgpath(m, 0); if (current_pgpath) { |