summaryrefslogtreecommitdiffstats
path: root/drivers/md/dm-raid.c
diff options
context:
space:
mode:
authorHeinz Mauelshagen <heinzm@redhat.com>2016-06-15 18:50:18 +0200
committerMike Snitzer <snitzer@redhat.com>2016-07-18 15:37:19 -0400
commit5fa146b25ba86682f74e3060debd4c4d3073561b (patch)
treee8dcfe62786f5a3510a01ecfb0f197c90275e53d /drivers/md/dm-raid.c
parent0a7b818892e27f6a6ac728a525bd0d8a307fe2bc (diff)
downloadlinux-5fa146b25ba86682f74e3060debd4c4d3073561b.tar.gz
linux-5fa146b25ba86682f74e3060debd4c4d3073561b.tar.bz2
linux-5fa146b25ba86682f74e3060debd4c4d3073561b.zip
dm raid: reject too many write_mostly devices
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-raid.c')
-rw-r--r--drivers/md/dm-raid.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 0eceee802571..a38298589db8 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -1025,7 +1025,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
{
int value, raid10_format = ALGORITHM_RAID10_DEFAULT;
unsigned raid10_copies = 2;
- unsigned i;
+ unsigned i, write_mostly = 0;
unsigned region_size = 0;
sector_t max_io_len;
const char *arg, *key;
@@ -1179,6 +1179,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
return -EINVAL;
}
+ write_mostly++;
set_bit(WriteMostly, &rs->dev[value].rdev.flags);
set_bit(__CTR_FLAG_WRITE_MOSTLY, &rs->ctr_flags);
} else if (!strcasecmp(key, dm_raid_arg_name_by_flag(CTR_FLAG_MAX_WRITE_BEHIND))) {
@@ -1303,6 +1304,11 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as,
return -EINVAL;
}
+ if (write_mostly >= rs->md.raid_disks) {
+ rs->ti->error = "Can't set all raid1 devices to write_mostly";
+ return -EINVAL;
+ }
+
if (validate_region_size(rs, region_size))
return -EINVAL;