diff options
| author | NeilBrown <neilb@cse.unsw.edu.au> | 2005-05-16 21:53:16 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-05-17 07:59:12 -0700 |
| commit | 7a5febe9ffeecd1e78c5b505260ccc1ef18021b4 (patch) | |
| tree | f3d61987a3f961f33a77334052805457a2ef2460 /drivers/md/raid1.c | |
| parent | 29ac8e056f2016a8404edc02749d095019aa1f82 (diff) | |
| download | linux-7a5febe9ffeecd1e78c5b505260ccc1ef18021b4.tar.gz linux-7a5febe9ffeecd1e78c5b505260ccc1ef18021b4.tar.bz2 linux-7a5febe9ffeecd1e78c5b505260ccc1ef18021b4.zip | |
[PATCH] md: set the unplug_fn and issue_flush_fn for md devices *after* committed to creation
We we set the too early, they may still be in place and possibly get called
even though the array didn't get set up properly.
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/raid1.c')
| -rw-r--r-- | drivers/md/raid1.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 83380b5d6593..1db5de52d376 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1197,10 +1197,6 @@ static int run(mddev_t *mddev) if (!conf->r1bio_pool) goto out_no_mem; - mddev->queue->unplug_fn = raid1_unplug; - - mddev->queue->issue_flush_fn = raid1_issue_flush; - ITERATE_RDEV(mddev, rdev, tmp) { disk_idx = rdev->raid_disk; if (disk_idx >= mddev->raid_disks @@ -1282,6 +1278,9 @@ static int run(mddev_t *mddev) */ mddev->array_size = mddev->size; + mddev->queue->unplug_fn = raid1_unplug; + mddev->queue->issue_flush_fn = raid1_issue_flush; + return 0; out_no_mem: |