diff options
| author | Tomasz Majchrzak <tomasz.majchrzak@intel.com> | 2016-06-13 15:51:19 +0200 |
|---|---|---|
| committer | Shaohua Li <shli@fb.com> | 2016-06-13 11:54:11 -0700 |
| commit | 7ac504472263180745ac94242f1d253eb7284e48 (patch) | |
| tree | ccdbd22c6056ece215ab630629e76556e98ffa34 /drivers/md/raid1.c | |
| parent | 4ba1e78891e9858a5c773e6ffe4414611019bf42 (diff) | |
| download | linux-7ac504472263180745ac94242f1d253eb7284e48.tar.gz linux-7ac504472263180745ac94242f1d253eb7284e48.tar.bz2 linux-7ac504472263180745ac94242f1d253eb7284e48.zip | |
raid1/raid10: slow down resync if there is non-resync activity pending
A performance drop of mkfs has been observed on RAID10 during resync
since commit 09314799e4f0 ("md: remove 'go_faster' option from
->sync_request()"). Resync sends so many IOs it slows down non-resync
IOs significantly (few times). Add a short delay to a resync. The
previous long sleep (1s) has proven unnecessary, even very short delay
brings performance right.
The change also applied to raid1. The problem has not been observed on
raid1, however it shares barriers code with raid10 so it might be an
issue for some setup too.
Suggested-by: NeilBrown <neilb@suse.com>
Link: http://lkml.kernel.org/r/20160609134555.GA9104@proton.igk.intel.com
Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'drivers/md/raid1.c')
| -rw-r--r-- | drivers/md/raid1.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index c7c8cde0ab21..358a08e656f6 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2535,6 +2535,13 @@ static sector_t raid1_sync_request(struct mddev *mddev, sector_t sector_nr, return sync_blocks; } + /* + * If there is non-resync activity waiting for a turn, then let it + * though before starting on this new sync request. + */ + if (conf->nr_waiting) + schedule_timeout_uninterruptible(1); + /* we are incrementing sector_nr below. To be safe, we check against * sector_nr + two times RESYNC_SECTORS */ |