diff options
author | Coly Li <colyli@suse.de> | 2020-01-24 01:01:29 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2020-01-23 11:40:01 -0700 |
commit | 29cda393bcaad160c4bf3676ddd99855adafc72f (patch) | |
tree | 157f8dc5919fdfd60a86e74fc403d50d19826c38 /drivers/md | |
parent | 50246693f81fe887f4db78bf7089051d7f1894cc (diff) | |
download | linux-29cda393bcaad160c4bf3676ddd99855adafc72f.tar.gz linux-29cda393bcaad160c4bf3676ddd99855adafc72f.tar.bz2 linux-29cda393bcaad160c4bf3676ddd99855adafc72f.zip |
bcache: properly initialize 'path' and 'err' in register_bcache()
Patch "bcache: rework error unwinding in register_bcache" from
Christoph Hellwig changes the local variables 'path' and 'err'
in undefined initial state. If the code in register_bcache() jumps
to label 'out:' or 'out_module_put:' by goto, these two variables
might be reference with undefined value by the following line,
out_module_put:
module_put(THIS_MODULE);
out:
pr_info("error %s: %s", path, err);
return ret;
Therefore this patch initializes these two local variables properly
in register_bcache() to avoid such issue.
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md')
-rw-r--r-- | drivers/md/bcache/super.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index e8013e1b0a14..ee7c87f38d0d 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2376,18 +2376,20 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, const char *buffer, size_t size) { const char *err; - char *path; + char *path = NULL; struct cache_sb *sb; struct block_device *bdev = NULL; struct page *sb_page; ssize_t ret; ret = -EBUSY; + err = "failed to reference bcache module"; if (!try_module_get(THIS_MODULE)) goto out; /* For latest state of bcache_is_reboot */ smp_mb(); + err = "bcache is in reboot"; if (bcache_is_reboot) goto out_module_put; |