diff options
| author | Jan Kara <jack@suse.cz> | 2017-09-06 14:25:51 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2017-09-06 08:17:33 -0600 |
| commit | 4b758df21ee7081ab41448d21d60367efaa625b3 (patch) | |
| tree | 7fe339d622132fd3d83689105f3d946dcfc77a50 /drivers/md | |
| parent | bc75705d00637c5f7b0346bf63094a9899c3d516 (diff) | |
| download | linux-4b758df21ee7081ab41448d21d60367efaa625b3.tar.gz linux-4b758df21ee7081ab41448d21d60367efaa625b3.tar.bz2 linux-4b758df21ee7081ab41448d21d60367efaa625b3.zip | |
bcache: Fix leak of bdev reference
If blkdev_get_by_path() in register_bcache() fails, we try to lookup the
block device using lookup_bdev() to detect which situation we are in to
properly report error. However we never drop the reference returned to
us from lookup_bdev(). Fix that.
Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Coly Li <colyli@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/bcache/super.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 974d832e54a6..c3fedd265d18 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1964,6 +1964,8 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, else err = "device busy"; mutex_unlock(&bch_register_lock); + if (!IS_ERR(bdev)) + bdput(bdev); if (attr == &ksysfs_register_quiet) goto out; } |