diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2020-10-13 16:26:17 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-11-16 10:31:10 +0100 |
| commit | 9bb83e8fe252f15ad30430e80eb7f9da66cacbb9 (patch) | |
| tree | ca1f95dbced804e4a86cd4cb5bfb8891b7d82e0d /drivers/media/common/saa7146/saa7146_fops.c | |
| parent | d940d2f46bfec6e206609cf44c6bd612a81d117e (diff) | |
| download | linux-9bb83e8fe252f15ad30430e80eb7f9da66cacbb9.tar.gz linux-9bb83e8fe252f15ad30430e80eb7f9da66cacbb9.tar.bz2 linux-9bb83e8fe252f15ad30430e80eb7f9da66cacbb9.zip | |
media: Bulk remove BUG_ON(in_interrupt())
None of these BUG_ON()'s is justified. BUG_ON() should only be used when
there is really no way to survive.
If at all these could be replaced by lockdep_assert_preemption_enabled() to
cover all invalid caller context and not just those covered by
in_interrupt().
But all functions which are invoked from those places contain already debug
mechanisms to catch wrong context, so having these extra checks is not
having any advantage.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/common/saa7146/saa7146_fops.c')
| -rw-r--r-- | drivers/media/common/saa7146/saa7146_fops.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/media/common/saa7146/saa7146_fops.c b/drivers/media/common/saa7146/saa7146_fops.c index d6531874faa6..e936c56b0378 100644 --- a/drivers/media/common/saa7146/saa7146_fops.c +++ b/drivers/media/common/saa7146/saa7146_fops.c @@ -55,8 +55,6 @@ void saa7146_dma_free(struct saa7146_dev *dev,struct videobuf_queue *q, struct videobuf_dmabuf *dma=videobuf_to_dma(&buf->vb); DEB_EE("dev:%p, buf:%p\n", dev, buf); - BUG_ON(in_interrupt()); - videobuf_waiton(q, &buf->vb, 0, 0); videobuf_dma_unmap(q->dev, dma); videobuf_dma_free(dma); |