diff options
author | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-04-05 05:30:52 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2018-04-17 05:49:58 -0400 |
commit | 76d81243a487c09619822ef8e7201a756e58a87d (patch) | |
tree | e964364b17392bfc509abee06a2d3da935a357c1 /drivers/media/v4l2-core | |
parent | 65c1167373449c60708109b89e3117edf0074c62 (diff) | |
download | linux-76d81243a487c09619822ef8e7201a756e58a87d.tar.gz linux-76d81243a487c09619822ef8e7201a756e58a87d.tar.bz2 linux-76d81243a487c09619822ef8e7201a756e58a87d.zip |
media: dvb_frontend: fix locking issues at dvb_frontend_get_event()
As warned by smatch:
drivers/media/dvb-core/dvb_frontend.c:314 dvb_frontend_get_event() warn: inconsistent returns 'sem:&fepriv->sem'.
Locked on: line 288
line 295
line 306
line 314
Unlocked on: line 303
The lock implementation for get event is wrong, as, if an
interrupt occurs, down_interruptible() will fail, and the
routine will call up() twice when userspace calls the ioctl
again.
The bad code is there since when Linux migrated to git, in
2005.
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/v4l2-core')
0 files changed, 0 insertions, 0 deletions