summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorJon Burgess <jburgess@uklinux.net>2005-09-27 21:45:26 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-09-28 07:46:40 -0700
commit88bdcc5d5e9a7ea280f99262f48b70aba9d949bf (patch)
tree2543d9a35e2ae0e6ff577065edd577ed5b1dfdb1 /drivers/media
parent0b8dd17762194ec77066d339e0b2866b0c66b715 (diff)
downloadlinux-88bdcc5d5e9a7ea280f99262f48b70aba9d949bf.tar.gz
linux-88bdcc5d5e9a7ea280f99262f48b70aba9d949bf.tar.bz2
linux-88bdcc5d5e9a7ea280f99262f48b70aba9d949bf.zip
[PATCH] dvb: fix NULL pointer dereference when loading the budget-av module
Ralph Metzler wrote: > AFAIR, there is a bug in tda10021.c in tda10021_readreg() which > references state->frontend.dvb->num > This is fatal if the frontend is not at the probed address and thus > not yet registered (no dvb entry set yet -> NULL pointer ...). The attached patch should get rid of the oops. Signed-off-by: Jon Burgess <jburgess@uklinux.net> Cc: Johannes Stezenbach <js@linuxtv.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/dvb/frontends/tda10021.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/dvb/frontends/tda10021.c b/drivers/media/dvb/frontends/tda10021.c
index 87d5f4d8790f..eaf130e666d8 100644
--- a/drivers/media/dvb/frontends/tda10021.c
+++ b/drivers/media/dvb/frontends/tda10021.c
@@ -100,8 +100,8 @@ static u8 tda10021_readreg (struct tda10021_state* state, u8 reg)
ret = i2c_transfer (state->i2c, msg, 2);
if (ret != 2)
- printk("DVB: TDA10021(%d): %s: readreg error (ret == %i)\n",
- state->frontend.dvb->num, __FUNCTION__, ret);
+ printk("DVB: TDA10021: %s: readreg error (ret == %i)\n",
+ __FUNCTION__, ret);
return b1[0];
}