summaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-08-23 02:11:12 +0200
committerUlf Hansson <ulf.hansson@linaro.org>2015-08-27 14:50:56 +0200
commit38276a912c9bb6dc48e21dc23a92b6286ca00962 (patch)
tree768d2934a9f4f1520819826d08453851b4a4a451 /drivers/mmc
parent3fe95db19be6a98bcb45d2780c6a90d1e96bfcc9 (diff)
downloadlinux-38276a912c9bb6dc48e21dc23a92b6286ca00962.tar.gz
linux-38276a912c9bb6dc48e21dc23a92b6286ca00962.tar.bz2
linux-38276a912c9bb6dc48e21dc23a92b6286ca00962.zip
mmc: omap: fix error return code
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/host/omap.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 70dcf074fbe3..b763b11ed9e1 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1420,8 +1420,10 @@ static int mmc_omap_probe(struct platform_device *pdev)
host->reg_shift = (mmc_omap7xx() ? 1 : 2);
host->mmc_omap_wq = alloc_workqueue("mmc_omap", 0, 0);
- if (!host->mmc_omap_wq)
+ if (!host->mmc_omap_wq) {
+ ret = -ENOMEM;
goto err_plat_cleanup;
+ }
for (i = 0; i < pdata->nr_slots; i++) {
ret = mmc_omap_new_slot(host, i);