diff options
| author | Fuqian Huang <huangfq.daxian@gmail.com> | 2019-07-15 11:19:11 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-07-15 11:06:27 -0700 |
| commit | 3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9 (patch) | |
| tree | bc48ce9996493d2db1151e6d200037db8076a69f /drivers/net/ethernet/atheros | |
| parent | cef86f1536b02e61e699f53b5f8782067481580d (diff) | |
| download | linux-3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9.tar.gz linux-3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9.tar.bz2 linux-3a5ee3b30126bd7dc5d6299f3a985d4fefcf42c9.zip | |
ethernet: remove redundant memset
kvzalloc already zeroes the memory during the allocation.
pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So the memset after these function is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/atheros')
| -rw-r--r-- | drivers/net/ethernet/atheros/atlx/atl1.c | 2 | ||||
| -rw-r--r-- | drivers/net/ethernet/atheros/atlx/atl2.c | 1 |
2 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/atheros/atlx/atl1.c b/drivers/net/ethernet/atheros/atlx/atl1.c index 7c767ce9aafa..b5c6dc914720 100644 --- a/drivers/net/ethernet/atheros/atlx/atl1.c +++ b/drivers/net/ethernet/atheros/atlx/atl1.c @@ -1060,8 +1060,6 @@ static s32 atl1_setup_ring_resources(struct atl1_adapter *adapter) goto err_nomem; } - memset(ring_header->desc, 0, ring_header->size); - /* init TPD ring */ tpd_ring->dma = ring_header->dma; offset = (tpd_ring->dma & 0x7) ? (8 - (ring_header->dma & 0x7)) : 0; diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index 3a3fb5ce0fee..3aba38322717 100644 --- a/drivers/net/ethernet/atheros/atlx/atl2.c +++ b/drivers/net/ethernet/atheros/atlx/atl2.c @@ -291,7 +291,6 @@ static s32 atl2_setup_ring_resources(struct atl2_adapter *adapter) &adapter->ring_dma); if (!adapter->ring_vir_addr) return -ENOMEM; - memset(adapter->ring_vir_addr, 0, adapter->ring_size); /* Init TXD Ring */ adapter->txd_dma = adapter->ring_dma ; |