diff options
| author | Joe Perches <joe@perches.com> | 2020-03-10 19:41:41 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-12 11:29:28 -0700 |
| commit | c7449b756943c6aae868b2f7c91c57bacbce61f6 (patch) | |
| tree | 2ae8d47710fa60ac77abd6a1e336f18bcaf12050 /drivers/net/ethernet/emulex | |
| parent | 7c4046b1c53bba3a0315f04bb0bb5f36888a747b (diff) | |
| download | linux-c7449b756943c6aae868b2f7c91c57bacbce61f6.tar.gz linux-c7449b756943c6aae868b2f7c91c57bacbce61f6.tar.bz2 linux-c7449b756943c6aae868b2f7c91c57bacbce61f6.zip | |
sfc: ethtool: Refactor to remove fallthrough comments in case blocks
Converting fallthrough comments to fallthrough; creates warnings
in this code when compiled with gcc.
This code is overly complicated and reads rather better with a
little refactoring and no fallthrough uses at all.
Remove the fallthrough comments and simplify the written source
code while reducing the object code size.
Consolidate duplicated switch/case blocks for IPV4 and IPV6.
defconfig x86-64 with sfc:
$ size drivers/net/ethernet/sfc/ethtool.o*
text data bss dec hex filename
10055 12 0 10067 2753 drivers/net/ethernet/sfc/ethtool.o.new
10135 12 0 10147 27a3 drivers/net/ethernet/sfc/ethtool.o.old
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Martin Habets <mhabets@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/emulex')
0 files changed, 0 insertions, 0 deletions