diff options
| author | Ivan Vecera <cera@cera.cz> | 2017-01-06 21:59:30 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-07 21:25:10 -0500 |
| commit | 6052cd1af86f9833b6b0b60d5d4787c4a06d65ea (patch) | |
| tree | d55983a658a481aefdc55f32512b14031155d492 /drivers/net/ethernet/emulex | |
| parent | 1d0f110a2c6c4bca3dbcc4b0e27f1e3dc2d44a2c (diff) | |
| download | linux-6052cd1af86f9833b6b0b60d5d4787c4a06d65ea.tar.gz linux-6052cd1af86f9833b6b0b60d5d4787c4a06d65ea.tar.bz2 linux-6052cd1af86f9833b6b0b60d5d4787c4a06d65ea.zip | |
be2net: fix unicast list filling
The adapter->pmac_id[0] item is used for primary MAC address but
this is not true for adapter->uc_list[0] as is assumed in
be_set_uc_list(). There are N UC addresses copied first from net_device
to adapter->uc_list[1..N] and then N UC addresses from
adapter->uc_list[0..N-1] are sent to HW. So the last UC address is never
stored into HW and address 00:00:00:00;00:00 (from uc_list[0]) is used
instead.
Cc: Sathya Perla <sathya.perla@broadcom.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Fixes: b717241 be2net: replace polling with sleeping in the FW completion path
Signed-off-by: Ivan Vecera <cera@cera.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/emulex')
| -rw-r--r-- | drivers/net/ethernet/emulex/benet/be_main.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 3510352866c2..ec010ced6c99 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -1695,9 +1695,8 @@ static void be_set_uc_list(struct be_adapter *adapter) } if (adapter->update_uc_list) { - i = 1; /* First slot is claimed by the Primary MAC */ - /* cache the uc-list in adapter array */ + i = 0; netdev_for_each_uc_addr(ha, netdev) { ether_addr_copy(adapter->uc_list[i].mac, ha->addr); i++; |