diff options
| author | Michael Ellerman <mpe@ellerman.id.au> | 2020-10-23 14:32:36 +1100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2020-10-23 18:44:06 -0700 |
| commit | dab234227cbdc6a088c6f9bce38b5dcfefe90832 (patch) | |
| tree | 36f26f537d7f28745eacad05c669877055d60963 /drivers/net/ethernet/freescale/ucc_geth.c | |
| parent | 0c3b7f4b812f708795fb5cc397432527421edc1b (diff) | |
| download | linux-dab234227cbdc6a088c6f9bce38b5dcfefe90832.tar.gz linux-dab234227cbdc6a088c6f9bce38b5dcfefe90832.tar.bz2 linux-dab234227cbdc6a088c6f9bce38b5dcfefe90832.zip | |
net: ucc_geth: Drop extraneous parentheses in comparison
Clang warns about the extra parentheses in this comparison:
drivers/net/ethernet/freescale/ucc_geth.c:1361:28:
warning: equality comparison with extraneous parentheses
if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII))
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
It seems clear the intent here is to do a comparison not an
assignment, so drop the extra parentheses to avoid any confusion.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201023033236.3296988-1-mpe@ellerman.id.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/freescale/ucc_geth.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/ucc_geth.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index 714b501be7d0..ba8869c3d891 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -1358,7 +1358,7 @@ static int adjust_enet_interface(struct ucc_geth_private *ugeth) (ugeth->phy_interface == PHY_INTERFACE_MODE_RTBI)) { upsmr |= UCC_GETH_UPSMR_TBIM; } - if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII)) + if (ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII) upsmr |= UCC_GETH_UPSMR_SGMM; out_be32(&uf_regs->upsmr, upsmr); |