summaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/xilinx/xilinx_emaclite.c
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-20 14:47:12 +0100
committerDavid S. Miller <davem@davemloft.net>2014-11-21 15:14:12 -0500
commit38a90e7ccb6c25a124ef46e1f30f5df1a0375fb6 (patch)
treec029e28e7b081bed1a0c439f3b09700d7fcec248 /drivers/net/ethernet/xilinx/xilinx_emaclite.c
parent5ac0fd00e1681ef6f929f651124da77f5ca7e564 (diff)
downloadlinux-38a90e7ccb6c25a124ef46e1f30f5df1a0375fb6.tar.gz
linux-38a90e7ccb6c25a124ef46e1f30f5df1a0375fb6.tar.bz2
linux-38a90e7ccb6c25a124ef46e1f30f5df1a0375fb6.zip
net: Xilinx: Deletion of unnecessary checks before two function calls
The functions kfree() and of_node_put() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/xilinx/xilinx_emaclite.c')
-rw-r--r--drivers/net/ethernet/xilinx/xilinx_emaclite.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 28dbbdc393eb..24858799c204 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1200,8 +1200,7 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
unregister_netdev(ndev);
- if (lp->phy_node)
- of_node_put(lp->phy_node);
+ of_node_put(lp->phy_node);
lp->phy_node = NULL;
xemaclite_remove_ndev(ndev);