diff options
| author | Eric Dumazet <edumazet@google.com> | 2021-11-19 07:43:32 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-11-22 12:49:42 +0000 |
| commit | 6d872df3e3b91532b142de9044e5b4984017a55f (patch) | |
| tree | 65f08dd7fd68e0584c00a3fb74077be873070a33 /drivers/net/macvlan.c | |
| parent | 4b66d2161b8125b6caa6971815e85631cf3cf36f (diff) | |
| download | linux-6d872df3e3b91532b142de9044e5b4984017a55f.tar.gz linux-6d872df3e3b91532b142de9044e5b4984017a55f.tar.bz2 linux-6d872df3e3b91532b142de9044e5b4984017a55f.zip | |
net: annotate accesses to dev->gso_max_segs
dev->gso_max_segs is written under RTNL protection, or when the device is
not yet visible, but is read locklessly.
Add netif_set_gso_max_segs() helper.
Add the READ_ONCE()/WRITE_ONCE() pairs, and use netif_set_gso_max_segs()
where we can to better document what is going on.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvlan.c')
| -rw-r--r-- | drivers/net/macvlan.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 506e9559df80..75b453acd778 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -901,7 +901,7 @@ static int macvlan_init(struct net_device *dev) dev->vlan_features |= ALWAYS_ON_OFFLOADS; dev->hw_enc_features |= dev->features; netif_set_gso_max_size(dev, lowerdev->gso_max_size); - dev->gso_max_segs = lowerdev->gso_max_segs; + netif_set_gso_max_segs(dev, lowerdev->gso_max_segs); dev->hard_header_len = lowerdev->hard_header_len; macvlan_set_lockdep_class(dev); @@ -1749,7 +1749,7 @@ static int macvlan_device_event(struct notifier_block *unused, case NETDEV_FEAT_CHANGE: list_for_each_entry(vlan, &port->vlans, list) { netif_set_gso_max_size(vlan->dev, dev->gso_max_size); - vlan->dev->gso_max_segs = dev->gso_max_segs; + netif_set_gso_max_segs(vlan->dev, dev->gso_max_segs); netdev_update_features(vlan->dev); } break; |