diff options
| author | Nicolas Dichtel <nicolas.dichtel@6wind.com> | 2018-11-29 14:45:39 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-11-30 17:31:03 -0800 |
| commit | 35b827b6d06199841a83839e8bb69c0cd13a28be (patch) | |
| tree | c1f0b4a3bd4cb90103cecd23122d207cfea74c72 /drivers/net/tun.c | |
| parent | 436c9453a1ac0944b82870ef2e0d9be956b396d9 (diff) | |
| download | linux-35b827b6d06199841a83839e8bb69c0cd13a28be.tar.gz linux-35b827b6d06199841a83839e8bb69c0cd13a28be.tar.bz2 linux-35b827b6d06199841a83839e8bb69c0cd13a28be.zip | |
tun: forbid iface creation with rtnl ops
It's not supported right now (the goal of the initial patch was to support
'ip link del' only).
Before the patch:
$ ip link add foo type tun
[ 239.632660] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
[snip]
[ 239.636410] RIP: 0010:register_netdevice+0x8e/0x3a0
This panic occurs because dev->netdev_ops is not set by tun_setup(). But to
have something usable, it will require more than just setting
netdev_ops.
Fixes: f019a7a594d9 ("tun: Implement ip link del tunXXX")
CC: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tun.c')
| -rw-r--r-- | drivers/net/tun.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/tun.c b/drivers/net/tun.c index e244f5d7512a..cf349e65a66b 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2293,9 +2293,9 @@ static void tun_setup(struct net_device *dev) static int tun_validate(struct nlattr *tb[], struct nlattr *data[], struct netlink_ext_ack *extack) { - if (!data) - return 0; - return -EINVAL; + NL_SET_ERR_MSG(extack, + "tun/tap creation via rtnetlink is not supported."); + return -EOPNOTSUPP; } static size_t tun_get_size(const struct net_device *dev) |