summaryrefslogtreecommitdiffstats
path: root/drivers/net/usb
diff options
context:
space:
mode:
authorzhong jiang <zhongjiang@huawei.com>2018-09-16 21:20:17 +0800
committerDavid S. Miller <davem@davemloft.net>2018-09-17 08:20:11 -0700
commit764ea3714a85bfc0e3e470cee2166b6ef911b9b9 (patch)
tree9b9ed2ab6b96e69e4eb8f82ce53d110ea5801403 /drivers/net/usb
parent1635bb548f846804af3054872fbd1395783ac03e (diff)
downloadlinux-764ea3714a85bfc0e3e470cee2166b6ef911b9b9.tar.gz
linux-764ea3714a85bfc0e3e470cee2166b6ef911b9b9.tar.bz2
linux-764ea3714a85bfc0e3e470cee2166b6ef911b9b9.zip
net: usb: remove redundant null pointer check before of_node_put
of_node_put has taken the null pointer check into account. So it is safe to remove the duplicated check before of_node_put. Signed-off-by: zhong jiang <zhongjiang@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/usb')
-rw-r--r--drivers/net/usb/lan78xx.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 95a98a20b2e3..04f0a094d864 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -1835,8 +1835,7 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev)
node = of_get_child_by_name(dev->udev->dev.of_node, "mdio");
ret = of_mdiobus_register(dev->mdiobus, node);
- if (node)
- of_node_put(node);
+ of_node_put(node);
if (ret) {
netdev_err(dev->net, "can't register MDIO bus\n");
goto exit1;