diff options
| author | Mugunthan V N <mugunthanvnm@ti.com> | 2014-06-18 17:21:48 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-06-21 17:17:39 -0700 |
| commit | e6afea0bbf129f88dc3fc39fd0d769f9ff064172 (patch) | |
| tree | 5756e77a38941017a8c64b42b846c317b662081a /drivers/net | |
| parent | 7f082319190bce121c9774956861c2457535ef2d (diff) | |
| download | linux-e6afea0bbf129f88dc3fc39fd0d769f9ff064172.tar.gz linux-e6afea0bbf129f88dc3fc39fd0d769f9ff064172.tar.bz2 linux-e6afea0bbf129f88dc3fc39fd0d769f9ff064172.zip | |
drivers: net: cpsw: fix dual EMAC stall when connected to same switch
In commit 629c9a8fd0bbdfc6d702526b327470166ec39c6b (drivers: net: cpsw: Add
default vlan for dual emac case also), api cpsw_add_default_vlan() also
changes the port vlan which is required to seperate the ports which results
in the following behavior
In Dual EMAC mode, when both the Etnernet connected is connected to same
switch, it creates a loop in the switch and when a broadcast packet is
received it is forwarded to the other port which stalls the whole switch
and needs a reset/power cycle to the switch to recover. So intead of using
the api, add only the default VLAN entry in dual EMAC case.
Cc: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Tested-by: Yegor Yefremov <yegorslists@googlemail.com>
Tested-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/ti/cpsw.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index ff380dac6629..b988d16cd34e 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -1212,7 +1212,12 @@ static int cpsw_ndo_open(struct net_device *ndev) for_each_slave(priv, cpsw_slave_open, priv); /* Add default VLAN */ - cpsw_add_default_vlan(priv); + if (!priv->data.dual_emac) + cpsw_add_default_vlan(priv); + else + cpsw_ale_add_vlan(priv->ale, priv->data.default_vlan, + ALE_ALL_PORTS << priv->host_port, + ALE_ALL_PORTS << priv->host_port, 0, 0); if (!cpsw_common_res_usage_state(priv)) { /* setup tx dma to fixed prio and zero offset */ |