diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-04-28 15:56:09 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-30 22:40:45 -0400 |
| commit | 66117a9d9a8ca948680d6554769ef9e88f936954 (patch) | |
| tree | 301444f835e3483a5ed454b0f9a809b2990842e2 /drivers/net | |
| parent | 1c942c941d3e209fb8729d0c0f6322d55b5e0444 (diff) | |
| download | linux-66117a9d9a8ca948680d6554769ef9e88f936954.tar.gz linux-66117a9d9a8ca948680d6554769ef9e88f936954.tar.bz2 linux-66117a9d9a8ca948680d6554769ef9e88f936954.zip | |
qed: Unlock on error in qed_vf_pf_acquire()
My static checker complains that we're holding a mutex on this error
path. Let's goto exit instead of returning directly.
Fixes: b0bccb69eba3 ("qed: Change locking scheme for VF channel")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_vf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_vf.c b/drivers/net/ethernet/qlogic/qed/qed_vf.c index c4c4a408b40b..11d71e5eea14 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_vf.c +++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c @@ -234,7 +234,7 @@ static int qed_vf_pf_acquire(struct qed_hwfn *p_hwfn) /* send acquire request */ rc = qed_send_msg2pf(p_hwfn, &resp->hdr.status, sizeof(*resp)); if (rc) - return rc; + goto exit; /* copy acquire response from buffer to p_hwfn */ memcpy(&p_iov->acquire_resp, resp, sizeof(p_iov->acquire_resp)); |