diff options
| author | Verma, Aashish <aashishx.verma@intel.com> | 2020-02-07 15:33:54 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-02-07 11:36:21 +0100 |
| commit | 2ba31cd93784b61813226d259fd94a221ecd9d61 (patch) | |
| tree | c024a2790da577867b9b4994cee5d0627ce173eb /drivers/net | |
| parent | 907a076881f171254219faad05f46ac5baabedfb (diff) | |
| download | linux-2ba31cd93784b61813226d259fd94a221ecd9d61.tar.gz linux-2ba31cd93784b61813226d259fd94a221ecd9d61.tar.bz2 linux-2ba31cd93784b61813226d259fd94a221ecd9d61.zip | |
net: stmmac: fix missing IFF_MULTICAST check in dwmac4_set_filter
Without checking for IFF_MULTICAST flag, it is wrong to assume multicast
filtering is always enabled. By checking against IFF_MULTICAST, now
the driver behaves correctly when the multicast support is toggled by below
command:-
ip link set <devname> multicast off|on
Fixes: 477286b53f55 ("stmmac: add GMAC4 core support")
Signed-off-by: Verma, Aashish <aashishx.verma@intel.com>
Tested-by: Tan, Tee Min <tee.min.tan@intel.com>
Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index 4d8eef9ff137..dc09d2131e40 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -420,7 +420,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw, value |= GMAC_PACKET_FILTER_PM; /* Set all the bits of the HASH tab */ memset(mc_filter, 0xff, sizeof(mc_filter)); - } else if (!netdev_mc_empty(dev)) { + } else if (!netdev_mc_empty(dev) && (dev->flags & IFF_MULTICAST)) { struct netdev_hw_addr *ha; /* Hash filter for multicast */ |