diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-12-15 14:59:03 +0100 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2024-02-09 15:59:28 +0000 |
| commit | 4df3bddf8707ae74bc5c8eb54e44a588a01e02e1 (patch) | |
| tree | ebde3b570502e6de62625ffe7d027c6c13b58f65 /drivers/perf | |
| parent | 94843f269abd4a9821848380061d05f0600b9d10 (diff) | |
| download | linux-4df3bddf8707ae74bc5c8eb54e44a588a01e02e1.tar.gz linux-4df3bddf8707ae74bc5c8eb54e44a588a01e02e1.tar.bz2 linux-4df3bddf8707ae74bc5c8eb54e44a588a01e02e1.zip | |
perf: arm-cci: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/70b581d58cfffdccb9fb3ed17bf3220c00f8033f.1702648124.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/perf')
| -rw-r--r-- | drivers/perf/arm-cci.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c index 61de861eaf91..6be03f81ae5d 100644 --- a/drivers/perf/arm-cci.c +++ b/drivers/perf/arm-cci.c @@ -1697,16 +1697,14 @@ error_pmu_init: return ret; } -static int cci_pmu_remove(struct platform_device *pdev) +static void cci_pmu_remove(struct platform_device *pdev) { if (!g_cci_pmu) - return 0; + return; cpuhp_remove_state(CPUHP_AP_PERF_ARM_CCI_ONLINE); perf_pmu_unregister(&g_cci_pmu->pmu); g_cci_pmu = NULL; - - return 0; } static struct platform_driver cci_pmu_driver = { @@ -1716,7 +1714,7 @@ static struct platform_driver cci_pmu_driver = { .suppress_bind_attrs = true, }, .probe = cci_pmu_probe, - .remove = cci_pmu_remove, + .remove_new = cci_pmu_remove, }; module_platform_driver(cci_pmu_driver); |