diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2020-07-23 11:36:22 +0000 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-08-17 09:37:12 +0530 |
| commit | 04db2304a9495b98b8976c9a8cc5f9845be35ba8 (patch) | |
| tree | e44204cb35e0afe1323a5596756e5a3b22f32e7f /drivers/phy/qualcomm | |
| parent | d86f9088938e637de5908ed463b023eee4d1b9e1 (diff) | |
| download | linux-04db2304a9495b98b8976c9a8cc5f9845be35ba8.tar.gz linux-04db2304a9495b98b8976c9a8cc5f9845be35ba8.tar.bz2 linux-04db2304a9495b98b8976c9a8cc5f9845be35ba8.zip | |
phy: qualcomm: fix return value check in qcom_ipq806x_usb_phy_probe()
In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.
Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200723113622.136752-1-weiyongjun1@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/qualcomm')
| -rw-r--r-- | drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c index 6707efd38680..9061ece7ff6a 100644 --- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c @@ -505,9 +505,9 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev) size = resource_size(res); phy_dwc3->base = devm_ioremap(phy_dwc3->dev, res->start, size); - if (IS_ERR(phy_dwc3->base)) { + if (!phy_dwc3->base) { dev_err(phy_dwc3->dev, "failed to map reg\n"); - return PTR_ERR(phy_dwc3->base); + return -ENOMEM; } phy_dwc3->ref_clk = devm_clk_get(phy_dwc3->dev, "ref"); |