summaryrefslogtreecommitdiffstats
path: root/drivers/phy
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2015-04-01 08:44:32 +0800
committerKishon Vijay Abraham I <kishon@ti.com>2015-04-03 18:16:21 +0530
commit247e21c613649f34bcf2f71e57e813e6ed18b458 (patch)
tree25c8c056422059dc3b6a281200e7276391a0dcb9 /drivers/phy
parentfbea230e7884044ee2e84bb28f6879dc30e1db24 (diff)
downloadlinux-247e21c613649f34bcf2f71e57e813e6ed18b458.tar.gz
linux-247e21c613649f34bcf2f71e57e813e6ed18b458.tar.bz2
linux-247e21c613649f34bcf2f71e57e813e6ed18b458.zip
phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate
The of_xlate callback should return ERR_PTR on error. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy')
-rw-r--r--drivers/phy/phy-spear1310-miphy.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
index 9f47fae7eecb..65ae640cfbd1 100644
--- a/drivers/phy/phy-spear1310-miphy.c
+++ b/drivers/phy/phy-spear1310-miphy.c
@@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev,
if (args->args_count < 1) {
dev_err(dev, "DT did not pass correct no of args\n");
- return NULL;
+ return ERR_PTR(-ENODEV);
}
priv->mode = args->args[0];
if (priv->mode != SATA && priv->mode != PCIE) {
dev_err(dev, "DT did not pass correct phy mode\n");
- return NULL;
+ return ERR_PTR(-ENODEV);
}
return priv->phy;