summaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl/pinconf.c
diff options
context:
space:
mode:
authorHaojian Zhuang <haojian.zhuang@gmail.com>2012-10-18 17:07:01 +0800
committerLinus Walleij <linus.walleij@linaro.org>2012-10-18 20:27:31 +0200
commit7ae9d71e8df27a3ab60a05ae3add08728debc09c (patch)
tree79afd74f0c1b57146cf69506b9ff6b6c56abc3f2 /drivers/pinctrl/pinconf.c
parenta03690e44468dcd3088f6600ab036d17bd2130ff (diff)
downloadlinux-7ae9d71e8df27a3ab60a05ae3add08728debc09c.tar.gz
linux-7ae9d71e8df27a3ab60a05ae3add08728debc09c.tar.bz2
linux-7ae9d71e8df27a3ab60a05ae3add08728debc09c.zip
pinctrl: remove mutex lock in groups show
Mutex is locked duplicatly by pinconf_groups_show() and pin_config_group_get(). It results dead lock. So avoid to lock mutex in pinconf_groups_show(). Cc: stable@kernel.org Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinconf.c')
-rw-r--r--drivers/pinctrl/pinconf.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 43f474cdc110..baee2cc46a17 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -537,8 +537,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
seq_puts(s, "Pin config settings per pin group\n");
seq_puts(s, "Format: group (name): configs\n");
- mutex_lock(&pinctrl_mutex);
-
while (selector < ngroups) {
const char *gname = pctlops->get_group_name(pctldev, selector);
@@ -549,8 +547,6 @@ static int pinconf_groups_show(struct seq_file *s, void *what)
selector++;
}
- mutex_unlock(&pinctrl_mutex);
-
return 0;
}