diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-06-09 13:18:14 +0900 |
|---|---|---|
| committer | Matthew Garrett <mjg@redhat.com> | 2012-06-26 14:43:33 -0400 |
| commit | 56f4a9f76d8ce7c7cef92905c909aad0c7e5c9db (patch) | |
| tree | c230f77cb978fc711fbbde612189ebd5991f6e82 /drivers/platform | |
| parent | c7a2918373983b32db3ca35823d930641747e26f (diff) | |
| download | linux-56f4a9f76d8ce7c7cef92905c909aad0c7e5c9db.tar.gz linux-56f4a9f76d8ce7c7cef92905c909aad0c7e5c9db.tar.bz2 linux-56f4a9f76d8ce7c7cef92905c909aad0c7e5c9db.zip | |
sony-laptop: fix a couple signedness bugs
This needs to be signed to handle negative error codes.
Remove a redundant check, read_limits is always called with a valid
handle.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mattia Dongili <malattia@linux.it>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/sony-laptop.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c index 78e6389d2cae..b9499b65c1cd 100644 --- a/drivers/platform/x86/sony-laptop.c +++ b/drivers/platform/x86/sony-laptop.c @@ -2139,7 +2139,7 @@ static ssize_t sony_nc_thermal_mode_show(struct device *dev, struct device_attribute *attr, char *buffer) { ssize_t count = 0; - unsigned int mode = sony_nc_thermal_mode_get(); + int mode = sony_nc_thermal_mode_get(); if (mode < 0) return mode; @@ -2507,8 +2507,6 @@ static void sony_nc_backlight_ng_read_limits(int handle, props->maxlvl = 0xff; offset = sony_find_snc_handle(handle); - if (offset < 0) - return; /* try to read the boundaries from ACPI tables, if we fail the above * defaults should be reasonable |