summaryrefslogtreecommitdiffstats
path: root/drivers/platform
diff options
context:
space:
mode:
authorQinglang Miao <miaoqinglang@huawei.com>2020-11-25 14:50:32 +0800
committerHans de Goede <hdegoede@redhat.com>2020-12-02 13:11:03 +0100
commit2425ccd30fd78ce35237350fe8baac31dc18bd45 (patch)
tree167b92ce30909102a935874c36dfc6ab00aae346 /drivers/platform
parentfe6000990394639ed374cb76c313be3640714f47 (diff)
downloadlinux-2425ccd30fd78ce35237350fe8baac31dc18bd45.tar.gz
linux-2425ccd30fd78ce35237350fe8baac31dc18bd45.tar.bz2
linux-2425ccd30fd78ce35237350fe8baac31dc18bd45.zip
platform/x86: dell-smbios-base: Fix error return code in dell_smbios_init
Fix to return the error code -ENODEV when fails to init wmi and smm. Fixes: 41e36f2f85af ("platform/x86: dell-smbios: Link all dell-smbios-* modules together") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> Reviewed-by: Mario Limonciello <mario.limonciello@dell.com> Link: https://lore.kernel.org/r/20201125065032.154125-1-miaoqinglang@huawei.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
-rw-r--r--drivers/platform/x86/dell-smbios-base.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 2e2cd565926a..3a1dbf199441 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -594,6 +594,7 @@ static int __init dell_smbios_init(void)
if (wmi && smm) {
pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
wmi, smm);
+ ret = -ENODEV;
goto fail_create_group;
}