summaryrefslogtreecommitdiffstats
path: root/drivers/power
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2015-10-10 14:30:51 +0200
committerSebastian Reichel <sre@kernel.org>2015-10-15 10:55:44 +0200
commit8e5cfb74bc9c8c12cf91d253b3d27753d54b0d86 (patch)
tree21224dac3ce54d4715dcb3b975940065dedf0908 /drivers/power
parent6169588f69f864c39f04e6d65cc620e58822aec5 (diff)
downloadlinux-8e5cfb74bc9c8c12cf91d253b3d27753d54b0d86.tar.gz
linux-8e5cfb74bc9c8c12cf91d253b3d27753d54b0d86.tar.bz2
linux-8e5cfb74bc9c8c12cf91d253b3d27753d54b0d86.zip
power_supply: charger-manager: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; | + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/power')
-rw-r--r--drivers/power/charger-manager.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/power/charger-manager.c b/drivers/power/charger-manager.c
index 907293e6f2a4..1ea5d1aa268b 100644
--- a/drivers/power/charger-manager.c
+++ b/drivers/power/charger-manager.c
@@ -1581,8 +1581,10 @@ static struct charger_desc *of_cm_parse_desc(struct device *dev)
cables = devm_kzalloc(dev, sizeof(*cables)
* chg_regs->num_cables,
GFP_KERNEL);
- if (!cables)
+ if (!cables) {
+ of_node_put(child);
return ERR_PTR(-ENOMEM);
+ }
chg_regs->cables = cables;